Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logical error in requireAddEvenNumbers function #1609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Exa1t
Copy link

@Exa1t Exa1t commented Jan 25, 2025

Fix logical error in requireAddEvenNumbers function
File: apps/base-docs/base-learn/docs/control-structures/control-structures.md

Change:

  • Old: require(_second % 2 != 0, "Second number is not even");
  • New: require(_second % 2 == 0, "Second number is not even");

Reason:
The current condition checks for odd numbers (!= 0) while the error message and function name indicate it should check for even numbers. Changed to check for even numbers (== 0) to align with function's purpose and maintain consistency with other examples.

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 5:32pm

Copy link

vercel bot commented Jan 25, 2025

@Exa1t is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants